Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(featured-articles): improve how Blog articles are shown #10624

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix(featured-articles): improve how Blog articles are shown #10624

merged 2 commits into from
Mar 5, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 29, 2024

Summary

Problem

In the "Featured articles" section on the homepage, Blog articles don't have a parent link, and short titles are aligned to the bottom.

Solution

  1. Add a "Blog" parent link for blog articles.
  2. Align titles to the top.

Screenshots

Before

image

After

image

How did you test this change?

Ran yarn dev (which calls yarn tool spas) and opened http://localhost:3000/en-US/.

@caugner caugner requested a review from a team as a code owner February 29, 2024 12:44
bsmth
bsmth approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@caugner caugner merged commit 4900d37 into main Mar 5, 2024
14 checks passed
@caugner caugner deleted the improve-featured-articles branch March 5, 2024 15:25
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
blog homepage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @bsmth